forked from KelvinTegelaar/CIPP
-
Notifications
You must be signed in to change notification settings - Fork 0
[pull] main from KelvinTegelaar:main #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pull
wants to merge
1,448
commits into
pjustdtech:main
Choose a base branch
from
KelvinTegelaar:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+77,319
−15,388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conditional rendering based on settings.isInitialized was removed from _app.js, allowing the main app components to render regardless of initialization state. Also, minor formatting changes were made to the CippTenantSelector effect dependencies for readability.
Simplifies tenant selection by making the URL parameter the single source of truth for tenant changes. Updates settings only when the URL changes, and removes redundant settings updates from the selection handler. Also streamlines effect dependencies and improves comments for clarity.
Introduced helper functions to remove unnecessary 'tenantFilter' query parameters and to clean 'AllTenants' from page titles in breadcrumbs. Updated all relevant breadcrumb and navigation logic to use these helpers, ensuring cleaner URLs and more accurate breadcrumb titles throughout the component. Added debug logging for easier troubleshooting.
Eliminated multiple console.log statements used for debugging in CippBreadcrumbNav.jsx to clean up the code and reduce console noise.
Moved and renamed standards-related pages for better organization, including aligning routes under /tenant/standards/alignment and /tenant/standards/templates. Updated navigation paths and tab options accordingly. Enhanced the alignment page with new drift management actions and removed obsolete files.
Refines the 'hasValue' comparison to better handle arrays and falsy values, ensuring more accurate condition evaluation. Also updates the prop validation to allow undefined compareValue only for 'hasValue' type.
Deleted the 'addedField' property from the ListIntuneTemplates-tag-autcomplete API config in standards.json to clean up unused configuration.
Simplifies tenant selection by making the URL parameter the single source of truth for tenant changes. Updates settings only when the URL changes, and removes redundant settings updates from the selection handler. Also streamlines effect dependencies and improves comments for clarity.
Introduced helper functions to remove unnecessary 'tenantFilter' query parameters and to clean 'AllTenants' from page titles in breadcrumbs. Updated all relevant breadcrumb and navigation logic to use these helpers, ensuring cleaner URLs and more accurate breadcrumb titles throughout the component. Added debug logging for easier troubleshooting.
Eliminated multiple console.log statements used for debugging in CippBreadcrumbNav.jsx to clean up the code and reduce console noise.
Moved and renamed standards-related pages for better organization, including aligning routes under /tenant/standards/alignment and /tenant/standards/templates. Updated navigation paths and tab options accordingly. Enhanced the alignment page with new drift management actions and removed obsolete files.
Refines the 'hasValue' comparison to better handle arrays and falsy values, ensuring more accurate condition evaluation. Also updates the prop validation to allow undefined compareValue only for 'hasValue' type.
Deleted the 'addedField' property from the ListIntuneTemplates-tag-autcomplete API config in standards.json to clean up unused configuration.
Changed all references from '/tenant/standards/list-standards' to '/tenant/standards' across components, hooks, and pages for consistency. Deleted the now-obsolete list-standards page implementation.
Added a getPathInfo helper to resolve breadcrumb titles from navigation or tab options and validate paths. Breadcrumbs now display titles from navigation/tabs when available and render invalid paths as plain text instead of clickable links.
Wrapped the CreateGroups switch in a CippFormCondition component to disable it unless 'Replace by display name' is selected. Added dynamic helper text to clarify group creation behavior based on the selected replace mode.
Update package.json and public/version.json to reflect the new version 8.8.2.
Introduces a tenant selector to the backup history view when 'AllTenants' is selected, allowing filtering of backup records by tenant. Updates backup display logic and UI to show tenant information and improve usability for multi-tenant scenarios.
Refactors appId refetching to only occur when applicationId is not already present, reducing unnecessary network calls. Adds retry logic with exponential backoff for the AADSTS650051 error during MSAL authentication, improving user experience when service principal consent issues occur.
Set relatedQueryKeys for ApiPostCall in CippTenantModeDeploy to improve cache management. Added queryKey prop to CippTablePage in CippTenantTable for more consistent data fetching.
Passed a scope prop with required Microsoft Graph permissions to the ConnectToTenantsButton component in CippTenantModeDeploy. This enables the button to request the minimum necessary permissions during authentication.
Sets required Microsoft Graph API scopes on the AuthButton component to enable necessary permissions for delegated permission grants, directory, and app role assignments.
Introduces a promptBeforeAuth prop to CIPPM365OAuthButton, displaying a confirmation dialog before starting authentication. Updates CippTenantModeDeploy to use this feature, prompting users when changing the partner tenant to prevent accidental changes.
Added display of current tenant and authenticated user information, including organization name, tenant ID, user display name, and partner status, to the CIPPDeploymentUpdateTokens component. Loading states with skeletons and partner type chips are also included for improved user feedback.
Calls appIdInfo.refetch() when the refresh token is stored successfully to ensure related data is updated. This helps keep the UI in sync with the latest authentication state.
- Changed action from "removeDevicePasscode" to "resetPasscode" - https://learn.microsoft.com/en-us/intune/intune-service/remote-actions/device-remove-passcode
Changed required permissions for the 'Setup Wizard' and 'Custom Data' menu items from 'CIPP.Core.*' to 'CIPP.AppSettings.*' to align with updated access control requirements.
Feat: Add standard to enable windows diagnostic data settings in Intune
- Introduced switches for "Add Organizer to Subject", "Delete Subject", and "Remove Canceled Meetings". - Updated state management to include new options in room settings.
- Introduced a refresh button with a loading animation to the Basic Information section. - The button allows users to refetch room information while indicating loading status.
Updated the InactiveLicensedUsers alert to allow customizable days since last login and added multiple input options for user configuration. Adjusted the alert label for clarity. Fixes #5273
Feat: Enhance inactive user alert functionality with dynamic days setting
Feat: Add calendar configuration options and refresh functionality
Fix: Fix removing passcode on iOS devices
feat: Update CI workflows to use ubuntu-slim
Dev to hotfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )